fix(evals): make llm_run.py fault-tolerant (save partial snapshot on failure)#699
Open
c990china wants to merge 2 commits into
Open
fix(evals): make llm_run.py fault-tolerant (save partial snapshot on failure)#699c990china wants to merge 2 commits into
c990china wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
evals/llm_run.py ran every prompt x arm with no error handling and subprocess.run(check=True). A single failed claude -p call (auth expiry, rate limit, transient network, or a bad CAVEMAN_EVAL_MODEL) aborted the entire multi-dollar run and wrote nothing - SNAPSHOT.write_text(...) is the last statement in main().
Reproduced locally: mocking subprocess.run to fail on the 2nd call makes the real main() crash with CalledProcessError after 2 calls, with no results.json produced.
Fix
Test
Verified locally: both cases pass.