Skip to content

Make Aqua.test_piracy recursive #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
giordano wants to merge 4 commits into
base: master
Choose a base branch
from
+33 −9
Open

Make Aqua.test_piracy recursive #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1bbbb46
Make `Aqua.test_piracy` recursive
giordano May 18, 2026
d29c189
Add more tests for recursive piracy
giordano May 19, 2026
cc766fd
Merge remote-tracking branch 'origin/master' into mg/recursive-piracy
giordano Jun 10, 2026
bb5ae5c
Reuse existing `walkmodules` function, but drop `recursive` argument
giordano Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/piracies.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module Piracy

using ..Aqua: is_kwcall, isType, type_parameter
using ..Aqua: is_kwcall, isType, type_parameter, walkmodules

using Test: is_in_mods

Expand Down Expand Up @@ -182,8 +182,12 @@ function is_pirate(meth::Method; treat_as_own = Union{Function,Type}[])
end

function hunt(mod::Module; skip_deprecated::Bool = true, kwargs...)
piracies = filter(all_methods(mod; skip_deprecated = skip_deprecated)) do method
method.module === mod && is_pirate(method; kwargs...)
piracies = Method[]
walkmodules(mod) do m
append!(piracies,
filter(all_methods(m; skip_deprecated = skip_deprecated)) do method
method.module === m && is_pirate(method; kwargs...)
end)
end
sort!(piracies, by = (m -> m.name))
return piracies
Expand Down
32 changes: 26 additions & 6 deletions test/test_piracy.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
push!(LOAD_PATH, joinpath(@__DIR__, "pkgs", "PiracyForeignProject"))

baremodule OuterPiracyModule
baremodule PiracyModule

using PiracyForeignProject: ForeignType, ForeignParameterizedType, ForeignNonSingletonType
Expand Down Expand Up @@ -60,9 +61,18 @@ Base.findmin(::Union{Foo,ForeignParameterizedType{Int}}, x::Int) = x + 1

end # PiracyModule

using Aqua: Piracy
baremodule NonPiracyModule
baremodule InnerModule
end # InnerModule
end # NonPiracyModule

end # OuterPiracyModule

using Aqua: Aqua, Piracy
using PiracyForeignProject: ForeignType, ForeignParameterizedType, ForeignNonSingletonType

const PiracyModule = OuterPiracyModule.PiracyModule

# Get all methods - test length
meths = filter(Piracy.all_methods(PiracyModule)) do m
m.module == PiracyModule
Expand All @@ -83,15 +93,22 @@ end
# Test what is foreign
BasePkg = Base.PkgId(Base)
CorePkg = Base.PkgId(Core)
ThisPkg = Base.PkgId(PiracyModule)

@test Piracy.is_foreign(Int, BasePkg; treat_as_own = []) # from Core
@test !Piracy.is_foreign(Int, CorePkg; treat_as_own = []) # from Core
@test !Piracy.is_foreign(Set{Int}, BasePkg; treat_as_own = [])
@test !Piracy.is_foreign(Set{Int}, CorePkg; treat_as_own = [])

# Check that `Aqua.walkmodules` finds all submodules.
all_mods = Module[]
Aqua.walkmodules(OuterPiracyModule) do x
push!(all_mods, x)
end
@test Set(all_mods) ==
Set([OuterPiracyModule, OuterPiracyModule.PiracyModule, OuterPiracyModule.NonPiracyModule, OuterPiracyModule.NonPiracyModule.InnerModule])

# Test what is pirate
pirates = Piracy.hunt(PiracyModule)
pirates = Piracy.hunt(OuterPiracyModule)
@test length(pirates) ==
3 + # findfirst
3 + # findmax
Expand All @@ -103,7 +120,7 @@ pirates = Piracy.hunt(PiracyModule)
end

# Test what is pirate (with treat_as_own=[ForeignType])
pirates = Piracy.hunt(PiracyModule, treat_as_own = [ForeignType])
pirates = Piracy.hunt(OuterPiracyModule, treat_as_own = [ForeignType])
@test length(pirates) ==
3 + # findfirst
3 + # findmin
Expand All @@ -113,7 +130,7 @@ pirates = Piracy.hunt(PiracyModule, treat_as_own = [ForeignType])
end

# Test what is pirate (with treat_as_own=[ForeignParameterizedType])
pirates = Piracy.hunt(PiracyModule, treat_as_own = [ForeignParameterizedType])
pirates = Piracy.hunt(OuterPiracyModule, treat_as_own = [ForeignParameterizedType])
@test length(pirates) ==
3 + # findfirst
3 + # findmax
Expand All @@ -136,7 +153,7 @@ pirates = filter(
end

# Test what is pirate (with treat_as_own=[Base.findfirst, Base.findmax])
pirates = Piracy.hunt(PiracyModule, treat_as_own = [Base.findfirst, Base.findmax])
pirates = Piracy.hunt(OuterPiracyModule, treat_as_own = [Base.findfirst, Base.findmax])
@test length(pirates) ==
3 + # findmin
1 + # ForeignType callable
Expand All @@ -159,3 +176,6 @@ pirates = filter(
meths,
)
@test length(pirates) == 0

# There's no piracy inside `NonPiracyModule`
@test isempty(Piracy.hunt(OuterPiracyModule.NonPiracyModule))
Loading