Preserve types in triangular constructors - #126
Open
jishnub wants to merge 6 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #126 +/- ##
==========================================
+ Coverage 93.87% 94.05% +0.17%
==========================================
Files 9 9
Lines 963 958 -5
==========================================
- Hits 904 901 -3
+ Misses 59 57 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jishnub
force-pushed
the
jishnub/triconstructor
branch
from
January 8, 2024 04:42
2de6b64 to
dd6d811
Compare
Contributor
Pull Request Test Coverage Report for Build 7443282799
💛 - Coveralls |
jishnub
force-pushed
the
jishnub/triconstructor
branch
from
January 10, 2024 05:04
dd6d811 to
5f38148
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
This is not ideal, as the
UpperTriangularconstructor should create an object of that type. This PR changes this toThis wrapper would allow one to use optimized
LinearAlgebrafunctions that are defined forUpperTriangular/LowerTriangular, although there is a certain degree of redundancy present.Similarly, change
Symmetric(::AbstractToeplitz)to return a wrapper instead of aSymmetricToeplitz.Since this was explicitly implemented this way and was being tested for, I have marked this change as breaking (minor version update). This also allows us to bump the Julia compatibility and drop support for v1.0. This should close #91.