Move *finite statistics functions from Images#13
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
==========================================
- Coverage 92.15% 90.96% -1.20%
==========================================
Files 4 5 +1
Lines 153 177 +24
==========================================
+ Hits 141 161 +20
- Misses 12 16 +4
Continue to review full report at Codecov.
|
Member
Author
|
Julia 1.0 is such a problem...I'm putting in a dirt-simple but slow workaround. |
Member
|
Do you think we need to set up documentation for this? Currently, I just list them as entries in README. Edit: I'll comment more on JuliaImages/Images.jl#898 |
Member
Author
|
It's a perennial question, distributed vs centralized. TBH I would defer to your judgement, you've spent more time thinking about this than me. |
johnnychen94
approved these changes
Aug 28, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A step towards JuliaImages/Images.jl#971
In one (not thorough) test, the implementation of
meanfinitewas ~3x faster than the one in Images, despite being far simpler. Those were written in an earlier era of Julia when we didn't even have fast anonymous functions.These are also more flexible since
minfiniteand friends now automatically accepts adimskwarg.