Skip to content

fix(skills): keep watcher startup from marking chats stale - #207

Merged
danyaberezun merged 3 commits into
mainfrom
skills-indicator-bug-investigation
Aug 10, 2026
Merged

fix(skills): keep watcher startup from marking chats stale#207
danyaberezun merged 3 commits into
mainfrom
skills-indicator-bug-investigation

Conversation

@danyaberezun

Copy link
Copy Markdown
Collaborator

Summary

  • publish the watcher's synthetic startup invalidation as pathless and non-truncated, so live readers still refresh without falsely marking every chat's skills stale
  • preserve conservative Skills staleness for real skill-path changes and genuinely truncated watcher batches
  • document the refined wire semantics and add store, watcher, and browser regression coverage

User-visible behavior

  • Before: opening a clean workspace could add the Skills reload dot after the watcher's delayed startup nudge, even though no skill changed
  • After: watcher startup leaves the Skills indicator clean; a real skill file change still raises it and Reload still clears it per chat

Verification

  • bun run check:deps
  • bun run check:seams
  • bun run lint (passes; reports the existing apps/website/src/styles.css specificity warning)
  • bun run typecheck
  • bun run test
  • bunx playwright test e2e/skills-reload.live.spec.ts
  • bun run e2e — 174 passed

@jetbrains-air jetbrains-air Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes — please address the blocking inline finding.

Comment thread packages/server/src/watch/watch.ts Outdated
@danyaberezun danyaberezun added the bug Something isn't working label Aug 10, 2026

@jetbrains-air jetbrains-air Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes — please address the blocking inline finding.

Comment thread packages/server/src/agent/skillSources.ts Outdated
jetbrains-air[bot]
jetbrains-air Bot previously approved these changes Aug 10, 2026

@jetbrains-air jetbrains-air Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved — ready to merge.

@jetbrains-air jetbrains-air Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved — ready to merge.

@danyaberezun
danyaberezun merged commit 34ab921 into main Aug 10, 2026
4 checks passed
@danyaberezun
danyaberezun deleted the skills-indicator-bug-investigation branch August 10, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant