Set up open search for local environment with all security harness - #386
Open
Dmitrii Krasnov (dkrasnoff) wants to merge 11 commits into
Conversation
…startup bootstrap (gated off by default)
…and package docs into OpenSearch
…GoodQuality from the project search repositories
…ories with shared query builder, moving search-index refresh orchestration into SearchService
…repositories with shared query builder, moving search-index refresh orchestration into SearchService
…uration hash and timestamp
…hentication, and trust-all certificates
Dmitrii Krasnov (dkrasnoff)
requested a review
from Nikita Vlaev (nikitavlaevjb)
August 7, 2026 18:38
Dmitrii Krasnov (dkrasnoff)
changed the base branch from
master
to
feature/KTL-4713-opensearch-index-generations
August 7, 2026 18:38
Nikita Vlaev (nikitavlaevjb)
requested changes
Aug 11, 2026
| } | ||
| httpClient.setConnectionManager( | ||
| PoolingAsyncClientConnectionManagerBuilder.create() | ||
| .setTlsStrategy(tlsStrategyBuilder.build()) |
Collaborator
There was a problem hiding this comment.
intellij says tlsStrategyBuilder.build() -- build() is deprecated
| it.setConnectionRequestTimeout(requestTimeout) | ||
| .setResponseTimeout(requestTimeout) | ||
| } | ||
| .setConnectionConfigCallback { |
Collaborator
There was a problem hiding this comment.
This is set on the default ConnectionManager, which then is replaced by your new httpClient.setConnectionManager.
Move it there?
| .setSslContext(trustAllSslContext()) | ||
| .setHostnameVerifier(NoopHostnameVerifier.INSTANCE) | ||
| } | ||
| httpClient.setConnectionManager( |
Collaborator
There was a problem hiding this comment.
AI notes:
We replaced the default connection manager from opensearch-java, thats why we lose
- Pool sizing regresses from 10/route, 30 total to the httpclient defaults of 5/25.
- The HTTPCLIENT-2219 tlsDetailsFactory workaround is lost.
| } | ||
|
|
||
| /** Trust-all [SSLContext] for local dev over https against a self-signed cert. Never enable in prod. */ | ||
| private fun trustAllSslContext(): SSLContext { |
Collaborator
There was a problem hiding this comment.
Use SSLContextBuilder.create().loadTrustMaterial(TrustAllStrategy.INSTANCE).build() instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.