fix(memory): Don't retain verification results in LoggingPluginVerificationReportageAggregator - #1580
Open
Ivan Chirkov (chrkv) wants to merge 1 commit into
Open
fix(memory): Don't retain verification results in LoggingPluginVerificationReportageAggregator#1580Ivan Chirkov (chrkv) wants to merge 1 commit into
LoggingPluginVerificationReportageAggregator#1580Ivan Chirkov (chrkv) wants to merge 1 commit into
Conversation
…d `PluginVerificationResult`. Use small `ReportLocation` instead.
Ivan Chirkov (chrkv)
requested review from
Flórián Garaba (fgaraba) and
Robert Novotny (novotnyr)
August 11, 2026 10:30
Robert Novotny (novotnyr)
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LoggingPluginVerificationReportageAggregatorkeeps everyPluginVerificationResultuntil verification is complete, even though the final aggregated output only needs the plugin and the directory where its report was written.A verification result may retain dependency graphs, compatibility problems, usages and other analysis data, so keeping all results alive unnecessarily increases memory usage on large verification runs.
Store only the plugin and report directory instead, allowing the rest of each verification result to be garbage-collected after it has been reported.