IJPL-249905 macOS: make project tab synchronization idempotent - #3569
Open
wyl0706 wants to merge 1 commit into
Open
IJPL-249905 macOS: make project tab synchronization idempotent#3569wyl0706 wants to merge 1 commit into
wyl0706 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
IJPL-249905
Root cause
JetBrains Client can queue multiple project-frame initialization updates while macOS has already merged the frames into one native tab group. The first update creates the complete Swing tab model, while a later update recreates the current frame's tab component and tries to insert the same
IdeFrameImplagain. This can leave the native window tab group and the IDE tab model out of sync, causing duplicate tabs, failed switching, or stuck tabs.Fix
IdeFrameImplalready present in the tab model.Tests
WindowTabsComponentTestcovering duplicate insertion of the same frame../tests.cmd --module intellij.platform.tests --test com.intellij.ui.mac.WindowTabsComponentTest