Skip to content

Address code review feedback

32930a1
Select commit
Loading
Failed to load commit list.
Draft

Add CDC support for mixed index mutations via Kafka #4874

Address code review feedback
32930a1
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis succeeded Oct 29, 2025 in 0s

Your pull request is up to standards!

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 2
           

Complexity increasing per file
==============================
- janusgraph-cdc/src/main/java/org/janusgraph/diskstorage/cdc/CdcConfiguration.java  17
- janusgraph-cdc/src/main/java/org/janusgraph/diskstorage/cdc/KafkaCdcProducer.java  18
- janusgraph-cdc/src/main/java/org/janusgraph/diskstorage/cdc/CdcIndexTransaction.java  34
- janusgraph-cdc/src/test/java/org/janusgraph/diskstorage/cdc/CdcMutationEventTest.java  3
- janusgraph-cdc/src/main/java/org/janusgraph/diskstorage/cdc/CdcMutationEvent.java  27
- janusgraph-cdc/src/main/java/org/janusgraph/diskstorage/cdc/CdcWorker.java  10
- janusgraph-cdc/src/main/java/org/janusgraph/diskstorage/cdc/CdcIndexTransactionFactory.java  8
- janusgraph-cdc/src/test/java/org/janusgraph/diskstorage/cdc/CdcKafkaIntegrationTest.java  6
- janusgraph-cdc/src/test/java/org/janusgraph/diskstorage/cdc/CdcConfigurationTest.java  3
         

See the complete overview on Codacy

Annotations

Check warning on line 61 in janusgraph-cdc/src/main/java/org/janusgraph/diskstorage/cdc/CdcMutationEvent.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

janusgraph-cdc/src/main/java/org/janusgraph/diskstorage/cdc/CdcMutationEvent.java#L61

Avoid unused method parameters such as 'additions'.

Check warning on line 189 in janusgraph-cdc/src/main/java/org/janusgraph/diskstorage/cdc/CdcWorker.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

janusgraph-cdc/src/main/java/org/janusgraph/diskstorage/cdc/CdcWorker.java#L189

Avoid throwing raw exception types.