Fix body property example key in recorded OpenAPI#36
Open
belka-fiz wants to merge 1 commit intoJamalZeynalov:masterfrom
Open
Fix body property example key in recorded OpenAPI#36belka-fiz wants to merge 1 commit intoJamalZeynalov:masterfrom
belka-fiz wants to merge 1 commit intoJamalZeynalov:masterfrom
Conversation
Body request properties were serialized with the field name as the
nested example key (`{k: value, "type": ...}`), producing non-standard
OpenAPI like `properties.product_type.product_type: income`. The Java
analyzer (`swagger-coverage-commandline`) expects the value at
`properties.<name>.example`, so it could not extract values for body
enum fields and reported `Checked values: [null, ...]` even when tests
sent real values.
Switch the key to the standard `example` so analyzers can read the
value. Effect: PropertyValueConditionPredicate now correctly sees the
sent values, flipping body enum-coverage rules from red to green.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Body request properties were serialized with the field name as the nested example key (
{k: value, "type": ...}), producing non-standard OpenAPI likeproperties.product_type.product_type: income. The Java analyzer (swagger-coverage-commandline) expects the value atproperties.<name>.example, so it could not extract values for body enum fields and reportedChecked values: [null, ...]even when tests sent real values.Switch the key to the standard
exampleso analyzers can read the value. Effect: PropertyValueConditionPredicate now correctly sees the sent values, flipping body enum-coverage rules from red to green.