Fix reporter.py for Windows#32
Open
nekdan wants to merge 1 commit intoJamalZeynalov:masterfrom
Open
Conversation
nekdan
force-pushed
the
reporter-windows
branch
2 times, most recently
from
547084a to
87c97ba
Compare
nekdan
force-pushed
the
reporter-windows
branch
from
87c97ba to
693580c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The report generation always used "swagger-coverage-commandline", but Windows does not support POSIX shell. Due to this, when running on Windows, an error appeared:
subprocess.py:1538: OSError: 1 is not a valid Win32 application.Therefore, I added an additional check, now if the system is Windows, then swagger-coverage-commandline.bat is used