You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds support for ARM processors. In my case, this means a quadcopter self-navigating for SAR. There are a number of possible uses, but in general PI and Nvidia Tegra's seem to run the small robotics world at the moment.
How
Including SSE2NEON.h only when SSE is not present keeps things nicely segregated - SSE2NEON takes care of all the translations, and any required compatibility fixes would belong to the upstream. There are other options such as simde; however they didn't work on the very first try :)
I've tried to keep this as loosely-coupled as possible. Ping me if you'd like any changes, such as just including SSE2NEON.h in the utils folder instead of using the submodule.
thanks!
I don't have a way of testing it on ARM, however given the comments it seems to work well!
I changed the ifdef checks to
#if !defined(SSE3) && !defined(SSE2) && !defined(SSE1)
(I only have SSE2 on my workstation, i.e. SSE3 is not defined and compilation failed).
@israelshirk Hi, it seems that in the newest NDK the codes fail to compile. The errors were:
AccumulatedTopHessian.s: Assembler messages:
AccumulatedTopHessian.s:28297: Error: r13 not allowed here -- `sub.w sp,r2,#80'
clang++: error: assembler command failed with exit code 1 (use -v to see invocation)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds support for ARM processors. In my case, this means a quadcopter self-navigating for SAR. There are a number of possible uses, but in general PI and Nvidia Tegra's seem to run the small robotics world at the moment.
How
Including SSE2NEON.h only when SSE is not present keeps things nicely segregated - SSE2NEON takes care of all the translations, and any required compatibility fixes would belong to the upstream. There are other options such as simde; however they didn't work on the very first try :)
Related issues
#57 and #31
Changes
I've tried to keep this as loosely-coupled as possible. Ping me if you'd like any changes, such as just including SSE2NEON.h in the utils folder instead of using the submodule.
Thanks! Israel