Skip to content

[SEC-6012] Enabling code scanning via Semgrep and triage via claude - #15

Open
randall-wyatt wants to merge 2 commits into
masterfrom
SEC-6012-enabling-code-scanning-via-semgrep
Open

[SEC-6012] Enabling code scanning via Semgrep and triage via claude#15
randall-wyatt wants to merge 2 commits into
masterfrom
SEC-6012-enabling-code-scanning-via-semgrep

Conversation

@randall-wyatt

@randall-wyatt randall-wyatt commented Jul 21, 2026

Copy link
Copy Markdown

SEC-6012

Description

  • Enables the code analysis workflow via Semgrep and triaging via claude

Comment on lines +13 to +15
concurrency:
group: codeql-${{ github.ref }}
cancel-in-progress: true

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo is very infrequently modified so it's not a big issue, but github.ref is the unique name of the branch that triggered the CI workflow. For pull_request events that's what you want, but for push events you typically don't want later commits to the main branch to cancel jobs running on earlier commits. Take a look at the bazel-ci.yml workflow in the BE repo for an alternative.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of needing to duplicate this CI workflow in many repos, have you looked into reusable GitHub Actions workflows? You can define them once, in a specific repo, and then "call" them from workflows in other repos. Search for kube-e2e in the Iterable GitHub organization for examples.

Or, you could even define an Action that can be used in any of our repos, like our existing security-custom-action or launchpad-publish-image-action.

Either way, it would mean that you'd only need to make a tiny stub workflow in each repo that has minimal configuration.

name: semgrep.sarif
path: semgrep.sarif

# triage_sarif_file:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not check in dead code. Either remove these lines if they're not going to be used, or uncomment them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants