[Docs] Add supported model tables to pretrain_sft advanced tutorial#1728
Open
CyCle1024 wants to merge 3 commits into
Open
[Docs] Add supported model tables to pretrain_sft advanced tutorial#1728CyCle1024 wants to merge 3 commits into
CyCle1024 wants to merge 3 commits into
Conversation
Collaborator
Author
|
@claude review |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
|
Claude: ## Summary Docs PR that replaces "Coming soon…" placeholders in the EN/ZH model advanced tutorial with comprehensive supported-model tables, inheritance hierarchy, and a Claude skill + scan script for keeping them in sync. IssuesCritical
Warning
Nit
VerdictREQUEST_CHANGES — the inheritance hierarchy errors affect 4 classes across 3 files (EN doc, ZH doc, SKILL.md) and would mislead users about the actual model config structure. |
jayhenry
approved these changes
Apr 29, 2026
| ## 继承关系 | ||
|
|
||
| 下图展示了 `TrainEngine` 支持的所有配置类的完整继承层级，包括 `TransformerConfig` 和 `BaseComposeConfig` 两大分支。 | ||
|
|
CyCle1024
force-pushed
the
docs/add-supported-models-table
branch
from
cfb8ec1 to
3bf9def
Compare
…ted-models skill - Add model support tables to en/zh pretrain_sft advanced tutorial model.md - Include base configs, concrete configs, compose models and inheritance hierarchy - Add xtuner-sync-supported-models skill under .claude/skills/ with scan script
CyCle1024
force-pushed
the
docs/add-supported-models-table
branch
from
3bf9def to
e0c7546
Compare
- Fix missing comma after 'scipy' in both en/zh conf.py
- Deduplicate 'torchvision' entries in autodoc_mock_imports
- Add 'fla' to autodoc_mock_imports to fix sphinx autosummary TypeError
- Add type hints to scan_file and main in scan_model_configs.py
- Remove redundant RELEVANT_BASES set (covered by p.endswith('Config'))
Claude review suggested that VL text backbone configs should be nested under their actual direct parent configs in the inheritance hierarchy tree, rather than as siblings under the family base class. - Qwen3VLTextDense4BConfig -> under Qwen3Dense4BConfig - Qwen3VLTextDense8BConfig -> under Qwen3Dense8BConfig - Qwen3VLTextMoE30BA3Config -> under Qwen3MoE30BA3Config - Qwen3VLTextMoE235BA22Config -> under Qwen3MoE235BA22Config The concrete model table is intentionally kept unchanged as it lists the base class / family for readability, which is a documentation choice separate from the technical inheritance hierarchy. Files updated: EN model.md, ZH model.md, SKILL.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive supported model documentation to the pretrain/sft advanced tutorial, replacing the previous "Coming soon..." placeholder.
Changes
English model doc ()
Chinese model doc ()
Skill for auto-sync ()
Supported models covered