Conversation
There was a problem hiding this comment.
Pull request overview
This PR bumps LMDeploy to v0.13.0 and aligns release/installation messaging and CI packaging to CUDA 12.8 as the default baseline for prebuilt wheels.
Changes:
- Bump package version to
0.13.0. - Update README install notes (EN/JA/ZH-CN) to reflect CUDA 12.8 default wheels on PyPI and remove the special-case wheel URL instructions.
- Update PyPI publishing workflow to build against CUDA 12.8 and remove the dedicated
cuda12.8_whl_releaseworkflow.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lmdeploy/version.py | Version bump to 0.13.0. |
| README.md | Update installation guidance to CUDA 12.8 default wheels. |
| README_zh-CN.md | Same installation guidance update (Chinese). |
| README_ja.md | Same installation guidance update (Japanese). |
| .github/workflows/pypi.yml | Switch build to CUDA 12.8 (Linux docker tag + Windows toolkit + wheel local tag). |
| .github/workflows/cuda12.8_whl_release.yml | Remove separate CUDA 12.8 GitHub-release workflow (now redundant with PyPI flow). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| run: | | ||
| python -m build --wheel -o build/wheel | ||
| Get-ChildItem -Path "build" -Filter "*.whl" | ForEach-Object { change_wheel_version $_.FullName --local-version cu121 --delete-old-wheel } | ||
| Get-ChildItem -Path "build" -Filter "*.whl" | ForEach-Object { change_wheel_version $_.FullName --local-version cu128 --delete-old-wheel } |
There was a problem hiding this comment.
In the Windows build step, python -m build --wheel -o build/wheel writes wheels under build/wheel, but the subsequent Get-ChildItem -Path "build" -Filter "*.whl" won’t find them (non-recursive), so change_wheel_version likely never runs. Point Get-ChildItem at build/wheel (or use -Recurse) so the local version update is actually applied (or remove the step if it’s not needed).
| Get-ChildItem -Path "build" -Filter "*.whl" | ForEach-Object { change_wheel_version $_.FullName --local-version cu128 --delete-old-wheel } | |
| Get-ChildItem -Path "build/wheel" -Filter "*.whl" | ForEach-Object { change_wheel_version $_.FullName --local-version cu128 --delete-old-wheel } |
No description provided.