Machine adc csv bsp int conversion warning#162
Open
jaenrig-ifx wants to merge 3 commits into
Open
Conversation
Signed-off-by: jaenrig-ifx <enriquezgarcia.external@infineon.com>
Signed-off-by: jaenrig-ifx <enriquezgarcia.external@infineon.com>
Signed-off-by: jaenrig-ifx <enriquezgarcia.external@infineon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would not suppress the warning during compilation. That -1 is not a valid value in our case, and add ignore to any other warning for this type of conversion.
The
extmod/machine_adc_blockis only used by esp32, therefore it has some port specific initialization.That should be fixed somehow in the
extmoditself, as each port implements a differentmp_hal_pin_obj_ttype.I though of just adding a macro which each port needs to define for itself. Maybe other ways would minimize adding changes to ports... That pin need to be initialized to -1?
But maybe a point for discussion when pushing to the upstream.