Skip to content

fix(igx-templates): fix side-nav layout stacking and scrolling issues #1702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ivanvpetrov wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(igx-templates): fix side-nav layout stacking and scrolling issues #1702

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0541ff4
fix(templates): layout of navdrawer
ivanvpetrov May 19, 2026
18e5493
fix(templates): navdrawer now fixed when scrolling
ivanvpetrov May 21, 2026
1125b26
fix(igx-templates): fix height chain and min-height for side-nav layout
ivanvpetrov May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions packages/igx-templates/igx-ts/projects/side-nav-auth/files/src/app/app.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
app-root {
overflow: hidden;
}

.outer-wrapper {
height: 100%;
overflow: hidden;
display: flex;
flex-direction: row;
}
Comment on lines +1 to +7

.main {
flex: 1;
min-width: 0;
min-height: 0;
overflow: hidden;
}

.content {
width: 100%;
display: flex;
flex-flow: row nowrap;
justify-content: center;
align-items: stretch;
overflow: auto;

> *:not(router-outlet) {
padding: 0 24px;
}

p {
margin: 15px;
}
}

@media only screen and (max-width: 1024px) {
.content {
justify-content: flex-start;

> *:not(router-outlet) {
padding: 0 15px;
}
}
}
2 changes: 1 addition & 1 deletion packages/igx-templates/igx-ts/projects/side-nav/files/src/app/app.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
}
</ng-template>
</igx-nav-drawer>
<div igxFlex igxLayout igxLayoutDir="columns">
<div class="main" igxFlex igxLayout igxLayoutDir="columns">
Comment on lines 1 to +10
Copy link
Copy Markdown
Member

@damyanpetev damyanpetev May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivanvpetrov Can you check the directives are actually active?
igxLayout on the .outer-wrapper is supposed to place it in display: flex; IIRC.
Simlartly with igxFlex on the .main. I'm assuming it's just the imports are missing?

Might want to check out https://www.infragistics.com/products/ignite-ui-angular/angular/components/layout to see what those directives added, recreate that in CSS as a starting point and actually remove the directives if they won't be used anymore.

Copy link
Copy Markdown
Member

@damyanpetev damyanpetev May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also not sure what scrolling issues there are, but you shouldn't have to spam that much overflow: hidden; (if at all) in a cleanly set up layout.

<igx-navbar title="<%=name%>" actionButtonIcon="menu" (action)="nav.toggle()"></igx-navbar>
<div class="content" igxFlex>
<router-outlet></router-outlet>
Expand Down
14 changes: 14 additions & 0 deletions packages/igx-templates/igx-ts/projects/side-nav/files/src/app/app.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,19 @@
app-root {
overflow: hidden;
}

.outer-wrapper {
height: 100%;
overflow: hidden;
display: flex;
flex-direction: row;
}

.main {
flex: 1;
min-width: 0;
min-height: 0;
overflow: hidden;
}

.content {
Expand Down
Loading