Skip to content

fix(grid): Fix state persistance timing issue for columns initialization. - #17434

Open
skrustev wants to merge 3 commits into
21.2.xfrom
skrastev/fix-16903-21.2.x
Open

fix(grid): Fix state persistance timing issue for columns initialization.#17434
skrustev wants to merge 3 commits into
21.2.xfrom
skrastev/fix-16903-21.2.x

Conversation

@skrustev

Copy link
Copy Markdown
Member

#16903

Description

Type of Change (check all that apply):

  • Bug fix
  • New functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes)
  • Documentation
  • Demos
  • CI/CD
  • Tests
  • Changelog
  • Skills/Agents

Component(s) / Area(s) Affected:

Grids, State Persistence

How Has This Been Tested?

  • Unit tests
  • Manual testing
  • Automated e2e tests

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them
  • Accessibility (ARIA, keyboard navigation, focus management) has been verified

@skrustev
skrustev requested a review from damyanpetev July 20, 2026 07:13
@skrustev skrustev added the ❌ status: awaiting-test PRs awaiting manual verification label Jul 20, 2026
Copilot AI review requested due to automatic review settings July 20, 2026 07:13
@skrustev
skrustev requested a review from MayaKirova July 20, 2026 07:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a grid state persistence timing problem when restoring column state, by avoiding column updates during a sensitive initialization/render window that can lead to change-detection glitches.

Changes:

  • Defers updateColumns() + columnInit emission until the grid’s rendered$ fires when the grid is initialized but not yet rendered.
  • Keeps immediate column restoration for all other cases.

Comment thread projects/igniteui-angular/grids/core/src/state-base.directive.ts
Comment thread projects/igniteui-angular/grids/core/src/state-base.directive.ts Outdated
@skrustev
skrustev force-pushed the skrastev/fix-16903-21.2.x branch from bc5ad42 to a6191eb Compare July 20, 2026 11:14
@mddragnev mddragnev added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

grid: state-persistence grid version: 21.2.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants