WIP: New Component: IpAddress#11696
Draft
phntxx wants to merge 2 commits into
Draft
Conversation
nicoroeser
reviewed
Jun 22, 2026
nicoroeser
left a comment
nicoroeser
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this pull request!
I’m giving some feedback which came to my mind. Others more experienced in these matters will surely have more and better advice.
Contributor
There was a problem hiding this comment.
This is the document about privacy matters. Giving some general information is OK in my eyes, but take care not to depend on people having read this file when they actually want what belongs in README.md. My feeling is that larger parts of this documentation would be better placed there. If they are urgently required to grasp the privacy-related parts of the component, then they should be summarised in this PRIVACY.md file.
In my opinion your descriptions here sound a bit better than those in README.md. 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft PR serves as preparation for the IpAddress Component.
Code will be added once the corresponding FRs have been approved by the ILIAS Jourfixe.
Corresponding Feature Requests: