Bugfix/creating a feature should be the default in the feature diagram editor #739#1760
Open
dbinkele wants to merge 15 commits into
Conversation
dbinkele
requested review from
kbirken and
mfsoliveira
and removed request for
arimer and
jonaskraemer
…ould-be-the-default-in-the-feature-diagram-editor-#739
…ould-be-the-default-in-the-feature-diagram-editor-#739
…ould-be-the-default-in-the-feature-diagram-editor-#739
kbirken
requested changes
Jun 11, 2026
kbirken
left a comment
kbirken
left a comment
Member
There was a problem hiding this comment.
When a new node in the feature model tree is created, it is always a Feature now. The ticket says
switching a Feature to a FeatureInclude should be done differently (e.g., via pressing :)
Unfortunately, pressing : after the feature name does not convert it into a FeatureModelInclude anymore (the ticket still assumes this is working, but we obviously had a regression). Now the only way to create a FeatureModelInclude is by intention. Pls. fix the regression, so that pressing : converts a Feature to a FeatureInclude. Also add a test so that functionality does not get lost anymore.
…ould-be-the-default-in-the-feature-diagram-editor-#739
…ould-be-the-default-in-the-feature-diagram-editor-#739
…ould-be-the-default-in-the-feature-diagram-editor-#739
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solves IETS3/iets3.core#739