Unit Testing for gtep_data.py#53
Conversation
|
waiting on PR #61 to be merged. |
belle-storm
changed the title
|
ready for review |
blnicho
left a comment
blnicho
left a comment
There was a problem hiding this comment.
@belle-storm the structure of this testing file seems more complex than I would have expected and doesn't match the format of the other testing files. It would be helpful if you could walk me through the logic here.
blnicho
left a comment
blnicho
left a comment
There was a problem hiding this comment.
@belle-storm here are the rest of my review comments in addition to what we talked about today.
| self.representative_weights = { | ||
| key: weight_per_date | ||
| for date, key in enumerate(self.representative_dates) | ||
| for key, date in enumerate(self.representative_dates) |
There was a problem hiding this comment.
Why did the order of key and date change here?
There was a problem hiding this comment.
In our conversation on Monday, we talked about whether the key should be the index or the date itself.
The previous version of representative_weights that was hard coded in (prior to #61) , used the index as the key to call.
I'm not sure why it was swapped throughout the iterations, but it seems like it should be swapped back.
2 participants
Fixes #48