Skip to content

fix: image loading in BitmaskRegion (fix: #8544) #8589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CLupoW wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: image loading in BitmaskRegion (fix: #8544) #8589

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28e531d
Implement image loading fallback with onload (fix: #8544)
CLupoW Dec 8, 2025
40aa249
Clarify image.onload handling for Chromium bug
CLupoW Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions web/libs/editor/src/regions/BitmaskRegion.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,16 +176,19 @@ const Model = types

image.src = self.imageDataURL;

try {
await image.decode();
// Fallback onload
image.onload = () => {
context.canvas.width = image.naturalWidth;
context.canvas.height = image.naturalHeight;
bitmask.width = image.naturalWidth;
bitmask.height = image.naturalHeight;

context.drawImage(image, 0, 0);

self.finalizeRegion();
};

try {
await image.decode();
image.onload(); // on success of decode() onload() get called manually
} catch (err) {
console.log(err);
}
Expand Down
Loading