Conversation
This comment was marked as outdated.
This comment was marked as outdated.
5414366 to
5c1bd02
Compare
This comment was marked as outdated.
This comment was marked as outdated.
4ce91c5 to
a04c02e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
tunetheweb
left a comment
There was a problem hiding this comment.
Can we pull the SQL into a separate PR? Both those and the chapter might require some iterations (I've not looked closely yet!) so let's merge them separately.
I see you reuses resource hints hero image for this chapter - good idea! I was wondering how to handle that — I was considering using Generative AI for to create one, but this works just as good.
a8e8c5e to
f7b9574
Compare
@tunetheweb I moved the queries to the separate PR #4302.
Yes, I think it works surprisingly well! 😊 |
tunetheweb
left a comment
There was a problem hiding this comment.
Looking great!
Made some comments, but I'd personally advise reconsidering direct references to figures ("see figure 7.1") and instead present in the context of the test ("see the following figure") as easier to manage, doesn't require a linting override, and less likely to reference the wrong number if a new figure is inserted, or one removed.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Barry Pollard <barrypollard@google.com>
|
@tunetheweb Let me flip the following figures, then we should be good to go. |
|
@tunetheweb I've flipped the figures and removed the "(see figure below)" references. However, I've kept the big numbers after the relevant sections in the text, hope this is fine. |
SGTM! It's highlighting something you've already mentioned, so is different to presenting the data. Good to merge then? |
|
@tunetheweb Yes, good to merge! |
|
Still a couple of questions on the SQL PR that might slightly change some of the graphs, but let’s merge this and can update later if needs be. |
|
will look throught the comments tomorrow and run some again just incase |
|
I think most of them are just SQL formatting nits. But the date one might lead to slightly different (smoother?) graphs. And the AI one might change numbers slightly. Let’s hold off for one more day then. |
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 23.9%, saving 5.3 KB.
22 images did not require optimisation. |
Closes #4104
Staged: https://generative-ai-2025-dot-webalmanac.uk.r.appspot.com/en/2025/generative-ai
Home page quotes: https://generative-ai-2025-dot-webalmanac.uk.r.appspot.com/en/2025/?feat=generative-ai#featured-chapter