Replace status tooltip with details modal#3025
Conversation
将“上传”按钮的颜色改成了黄色,将“全部”按钮的边框颜色改成了棕色,将黑色加粗字体的大小改到了26px(一号)
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 330f7d9d10
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
- Drop speculative `extraction_format`/`engine` cast (not in DocStatusResponse, no backend route emits them). - Suppress tooltip flash after dialog close via `onCloseAutoFocus` preventDefault on DialogContent. - Collapse trigger nesting to `<DialogTrigger asChild><Button tooltip ...>`, matching existing dialog patterns and removing a per-row TooltipProvider. - Replace native `title` on file/summary cells with styled Tooltip components, sharing a single TooltipProvider lifted to the table root. - Remove unreachable empty-details guard in DocumentStatusDetailsDialog. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Pushed a follow-up commit (0496d44) addressing the review points:
Verified with `bun run build` (✓ 1.67s). Existing `react-hooks/set-state-in-effect` lint errors at lines 1131/1150/1156 pre-date this PR and are unrelated. |
…om spacing - Prevent the copy button's tooltip from auto-showing when the dialog opens. Radix FocusScope was focusing the first tabbable child (the copy button), and TooltipTrigger's focus listener fired the tooltip. Redirect initial focus to DialogContent itself. - Drop `min-h-[7.5em]` on the details box. With short content (e.g. Track ID + 2 metadata lines) the min-height padded the box taller than its content, leaving a visible empty band below the last line. Letting the box size to content removes that gap; max-h still caps long content for scrolling. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Pushed another follow-up (7499017) addressing two display issues observed when opening the modal: 1. Copy button tooltip auto-shows on dialog open onOpenAutoFocus={(e) => {
e.preventDefault()
;(e.currentTarget as HTMLElement | null)?.focus()
}}
2. Empty band below the last line of details |
Description
Replace the document status hover tooltip with a click-triggered details dialog. The dialog displays the existing status information in a scrollable content area and includes a dedicated copy button for long error messages or metadata.
Related Issues
N/A
Changes Made
Checklist
Additional Notes
Frontend checks were run with
bun testandbun run buildinlightrag_webui/.