CI: base draft PR staleness on real activity, not pr.updated_at#6472
Merged
brtnfld merged 1 commit intoJun 19, 2026
Merged
Conversation
pr.updated_at is bumped by metadata-only changes (reviewer requested/removed, labels, milestone, assignee), letting an abandoned draft dodge the staleness check indefinitely. Use the latest commit/comment/review/review-comment timestamp instead.
brtnfld
requested review from
glennsong09,
hyoklee,
jhendersonHDF and
lrknox
as code owners
Contributor
Review ChecklistThis PR touches the following areas. Each needs a sign-off
|
lrknox
approved these changes
Jun 19, 2026
github-project-automation
Bot
moved this from To be triaged
to Done
in HDF5 - TRIAGE & TRACK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
draft-pr-policy.jsdecided whether a draft PR is stale by checkingdaysSince(pr.updated_at), but GitHub bumpsupdated_aton metadata-only changes (reviewer requested/removed, labels, milestone, assignee) with no real work happening.lastRealActivityAt(), which takes the max timestamp across the PR's commits, issue comments, reviews, and review comments, and uses that instead ofpr.updated_atfor the staleness gate.