Skip to content

Fix CMake config file install paths to follow platform conventions #6174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lrknox wants to merge 3 commits into
base: develop
Choose a base branch
from
+32 −8
Draft

Fix CMake config file install paths to follow platform conventions #6174

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02501aa
Fix CMake config file install paths to follow platform conventions
lrknox Jan 26, 2026
b4e4b18
Remove unnecessary code per review comment.
lrknox Jan 26, 2026
b86e079
Merge branch 'develop' of https://github.com/HDFGroup/hdf5 into fix-s…
lrknox Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 30 additions & 6 deletions config/HDFMacros.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,14 @@ endmacro ()
# HDF_DIR_PATHS: Set up install directory variables and RPATHs.
macro (HDF_DIR_PATHS package_prefix)
option (HDF5_USE_GNU_DIRS "ON to use GNU Coding Standard install directory variables, OFF to use historical settings" OFF)

if (APPLE)
option (${package_prefix}_BUILD_FRAMEWORKS "ON to build as frameworks libraries, OFF to build according to BUILD_SHARED_LIBS" OFF)
endif ()

# Derive lowercase package name for cmake config directory
string (TOLOWER ${package_prefix} ${package_prefix}_PACKAGE_NAME_LOWER)

if (HDF5_USE_GNU_DIRS)
include(GNUInstallDirs)
if (NOT ${package_prefix}_INSTALL_BIN_DIR)
Expand All @@ -442,18 +450,24 @@ macro (HDF_DIR_PATHS package_prefix)
set (${package_prefix}_INSTALL_DATA_DIR ${CMAKE_INSTALL_DATADIR})
endif ()
if (NOT ${package_prefix}_INSTALL_CMAKE_DIR)
set (${package_prefix}_INSTALL_CMAKE_DIR ${CMAKE_INSTALL_LIBDIR}/cmake)
# CMake config install directory:
# - Frameworks: <framework>/Resources/CMake/
# - Windows (not Cygwin): cmake/
# - Linux/Unix/Cygwin: ${CMAKE_INSTALL_LIBDIR}/cmake/<package_name>/
if (${package_prefix}_BUILD_FRAMEWORKS)

@jhendersonHDF jhendersonHDF Jan 26, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe only the Unixy changes need to be put in this particular spot. It seems unlikely that HDF5_USE_GNU_DIRS is going to be ON on Windows or Apple. There may be a use case for Apple, but that would seem to go against the frameworks approach anyway.

set (${package_prefix}_INSTALL_CMAKE_DIR ${CMAKE_INSTALL_FRAMEWORK_PREFIX}/${${package_prefix}_PACKAGE_NAME_LOWER}.framework/Resources/CMake)
elseif (WIN32 AND NOT CYGWIN)
set (${package_prefix}_INSTALL_CMAKE_DIR cmake)
else ()
set (${package_prefix}_INSTALL_CMAKE_DIR ${CMAKE_INSTALL_LIBDIR}/cmake/${${package_prefix}_PACKAGE_NAME_LOWER})
endif ()
endif ()
if (NOT ${package_prefix}_INSTALL_DOC_DIR)
set (${package_prefix}_INSTALL_DOC_DIR ${CMAKE_INSTALL_DOCDIR})
endif ()
message(STATUS "GNU: ${${package_prefix}_INSTALL_DOC_DIR}")
endif ()

if (APPLE)
option (${package_prefix}_BUILD_FRAMEWORKS "ON to build as frameworks libraries, OFF to build according to BUILD_SHARED_LIBS" OFF)
endif ()

if (NOT ${package_prefix}_INSTALL_BIN_DIR)
set (${package_prefix}_INSTALL_BIN_DIR bin)
endif ()
Expand Down Expand Up @@ -492,7 +506,17 @@ macro (HDF_DIR_PATHS package_prefix)
endif ()
endif ()
if (NOT ${package_prefix}_INSTALL_CMAKE_DIR)
set (${package_prefix}_INSTALL_CMAKE_DIR cmake)
# CMake config install directory:
# - Frameworks: <framework>/Resources/CMake/
# - Windows (not Cygwin): cmake/
# - Linux/Unix/Cygwin: <lib_dir>/cmake/<package_name>/
if (${package_prefix}_BUILD_FRAMEWORKS)
set (${package_prefix}_INSTALL_CMAKE_DIR ${CMAKE_INSTALL_FRAMEWORK_PREFIX}/${${package_prefix}_PACKAGE_NAME_LOWER}.framework/Resources/CMake)
elseif (WIN32 AND NOT CYGWIN)
set (${package_prefix}_INSTALL_CMAKE_DIR cmake)
else ()
set (${package_prefix}_INSTALL_CMAKE_DIR ${${package_prefix}_INSTALL_LIB_DIR}/cmake/${${package_prefix}_PACKAGE_NAME_LOWER})
endif ()
endif ()
if (NOT ${package_prefix}_INSTALL_DOC_DIR)
set (${package_prefix}_INSTALL_DOC_DIR ${${package_prefix}_INSTALL_DATA_DIR})
Expand Down
Loading