Skip to content

Turn IMappedRegistryAccess into an accessor mixin#5037

Open
jurrejelle wants to merge 3 commits into
1.21from
jj/fix-tests-remotely
Open

Turn IMappedRegistryAccess into an accessor mixin#5037
jurrejelle wants to merge 3 commits into
1.21from
jj/fix-tests-remotely

Conversation

@jurrejelle

Copy link
Copy Markdown
Contributor

What

A lot of methods were unused anyways, this was the only used thing it seems

AI Usage

  • No AI driven tools were used for this pull request.
  • Yes AI driven tools were used for this pull request.

Agent Used

Opus 5.8 High

Agent Usage Description

Helped troubleshoot / impl

Outcome

Tests should work

How Was This Tested

See build action

@jurrejelle jurrejelle requested a review from a team as a code owner June 30, 2026 08:06
@jurrejelle jurrejelle added 1.21 ignore changelog PR should not be added to the changelog. Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. type: tests Test related changes labels Jun 30, 2026
@github-actions github-actions Bot added the Tests: Failed Game Tests have failed on this PR label Jun 30, 2026
@github-actions github-actions Bot added Tests: Passed Game Tests have passed on this PR and removed Tests: Failed Game Tests have failed on this PR labels Jun 30, 2026
@jurrejelle jurrejelle changed the title Remove generic from IMappedRegistryAccess Turn IMappedRegistryAccess into an accessor mixin Jun 30, 2026
@screret

screret commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Maybe change the PR description to mention AI didn't help implement this one

@jurrejelle

Copy link
Copy Markdown
Contributor Author

Maybe change the PR description to mention AI didn't help implement this one

it did, it wrote the mixin, I'm ass at mixins LMAO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.21 ignore changelog PR should not be added to the changelog. Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. Tests: Passed Game Tests have passed on this PR type: tests Test related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants