Derive tooltip rates from the cover scaling functions (single source of truth)#4969
Open
Cyber1551 wants to merge 1 commit into
Open
Derive tooltip rates from the cover scaling functions (single source of truth)#4969Cyber1551 wants to merge 1 commit into
Cyber1551 wants to merge 1 commit into
Conversation
…of truth). Normalize PUMP_SCALING to match CONVEYOR_SCALING's format
screret
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The rate tooltips on the cover items (Conveyor, Robot Arm, Pump, Fluid Regulator) are hardcoded numbers in
GTItems, disconnected from the scaling functions that the covers actually use (ConveyorCover.CONVEYOR_SCALINGandPumpCover.PUMP_SCALING).Several are stale and currently display the wrong number, some examples:
this fix makes the tooltips use the scaling functions instead of a hardcoded value so they don't drift out of sync again.
Implementation Details
Two private helpers in
GTItemsreplace the hardcoded values. Robot Arm reusesCONVEYOR_SCALINGand Fluid Regulator reusesPUMP_SCALING, so only two helpers are needed for all cover types.Also, I tweaked
PUMP_SCALINGto matchCONVEYOR_SCALING's shape. The values are identical, but the oldmin(tier - 1, IV)looked like it capped at IV, when the rate actually caps at LuV. The newmin(tier, LuV) - 1is easier to follow imo.AI Usage
Outcome
Cover rate tooltips now match the actual configurable rate at every tier, and are calculated from the scaling functions so they stay correct if the scaling ever changes.
How Was This Tested
I checked the cover items tooltips in game at all tiers and confirmed the displayed rate matches the cover's GUI transfer rates.
Potential Compatibility Issues
None. This is a tooltip text change only. I added no behavior, recipe, or API changes.