Skip to content

feat: teleport sounds #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DesecratedTree wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

feat: teleport sounds #1099

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions engine/src/main/kotlin/world/gregs/voidps/engine/entity/character/player/Teleport.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import world.gregs.voidps.engine.entity.character.player.skill.Skill
import world.gregs.voidps.engine.entity.character.player.skill.exp.exp
import world.gregs.voidps.engine.entity.character.sound
import world.gregs.voidps.engine.entity.obj.GameObject
import world.gregs.voidps.network.login.protocol.encode.playSoundEffect
import world.gregs.voidps.engine.event.*
import world.gregs.voidps.engine.map.collision.random
import world.gregs.voidps.engine.queue.ActionPriority
Expand Down Expand Up @@ -116,6 +117,11 @@ interface Teleport {
player.exp(Skill.Magic, xp)
if (sound) {
player.sound("teleport_${type}")
if (type == "tablet") {

@GregHib GregHib Jul 19, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you add the ids as teleport_tablet and teleport_jewellery to .sounds.toml that should work

player.client?.playSoundEffect(965)
} else if (type != "jewellery") {
player.client?.playSoundEffect(200)
}
}
player.gfx("teleport_$type")
player.animDelay("teleport_$type")
Expand Down