fix: map blackscreen after teleport from differing height levels#1096
Open
DesecratedTree wants to merge 1 commit into
Open
fix: map blackscreen after teleport from differing height levels#1096DesecratedTree wants to merge 1 commit into
DesecratedTree wants to merge 1 commit into
Conversation
Contributor
|
This is lovely. I am amazed. |
Owner
|
Hmm I've never encountered this before, would it trigger using ladders to change levels? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause identified: Client's method3157 has a guard condition that states if zoneX == storedZoneX && zoneY == storedZoneY && !forceRefresh, the body is skipped, leaving scene data cleared by method3120 but never repopulated → black map.
Fix applied: Added Z-level check to inViewOfZone in RegionLoading.kt:99 which previously only checked X/Y, so teleports to the same zone coordinates but different plane (e.g., surface↔dungeon) would NOT trigger a region reload, causing the player to have a black map.
