fix: support VDF archives larger than 2 GiB - #130
Open
FadedAtlas wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
VDF archives >= 2 GiB fail to load on Windows (MinGW), reporting an empty signature.
The read fails outright, so the buffer stays zeroed and the parser sees null bytes where the signature should be.
Two bugs chain together
The Win32 mmap check fails to compile on GCC 14+:
CreateFile+ wide literal =CreateFileA, silently leaving_ZK_WITH_MMAPundefined.The resulting
std::ifstreamfallback then issues oneread()of the whole file, which under MinGW fails outright aboveINT32_MAX(2,147,483,647) returninggcount=0.Changes
support/BuildSupport.cmake:CreateFile->CreateFileW, matchingMmapWin32.cc. Re-enables memory mapping on MinGW.src/Vfs.cc: read VDF file in chunks.Result
"Vurt's Gothic II Graphics Overhaul.vdf" (2.39 GB) now mounts correctly.
Questions you may ask