Skip to content

Custom MAC addresses and NEG based Dynamic NICs support#17455

Open
Ray784 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Ray784:compute-astra
Open

Custom MAC addresses and NEG based Dynamic NICs support#17455
Ray784 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Ray784:compute-astra

Conversation

@Ray784
Copy link
Copy Markdown
Member

@Ray784 Ray784 commented May 7, 2026

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added new enum values to existing field `resolveSubnetMask` in `Subnetwork` resource
compute: added new enum value to existing field `networkEndpointType` in NetworkEndpointGroup resource

@github-actions github-actions Bot requested a review from NickElliot May 7, 2026 09:14
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 7, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 56391f0:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 6 insertions(+), 6 deletions(-)
google-beta provider View Diff 4 files changed, 6 insertions(+), 6 deletions(-)
terraform-google-conversion View Diff 2 files changed, 4 insertions(+), 4 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1433 1340 91 2
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceFromTemplate_DiskForceAttach
  • TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log - TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@Ray784, @NickElliot VCR tests complete for 56391f0!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 7, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 739e456:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 6 insertions(+), 6 deletions(-)
google-beta provider View Diff 4 files changed, 6 insertions(+), 6 deletions(-)
terraform-google-conversion View Diff 2 files changed, 4 insertions(+), 4 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1433 1339 91 3
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceFromTemplate_DiskForceAttach
  • TestAccComputeRouterPeer_AddMd5AuthenticationKey
  • TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeRouterPeer_AddMd5AuthenticationKey
❌ Error · Log - TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log - TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@Ray784, @NickElliot VCR tests complete for 739e456!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants