fix: honor -stderrthreshold when -logtostderr is set#664
Open
pierluigilenoci wants to merge 1 commit into
Open
fix: honor -stderrthreshold when -logtostderr is set#664pierluigilenoci wants to merge 1 commit into
pierluigilenoci wants to merge 1 commit into
Conversation
klog v2 defaults `-logtostderr=true`, which causes the `-stderrthreshold` flag to be silently ignored (kubernetes/klog#212). klog v2.140.0 introduced the `legacy_stderr_threshold_behavior` flag that restores correct behavior (kubernetes/klog#432). This commit: - Bumps k8s.io/klog/v2 from v2.130.1 to v2.140.0 in both the root module and the kubectl-utils submodule. - After every `klog.InitFlags()` call (cmd/main.go and kubectl-utils/cmd/kubectl-expect/main.go), sets `legacy_stderr_threshold_behavior=false` and `stderrthreshold=INFO` so that `-stderrthreshold` is honored regardless of `-logtostderr`. Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@gmail.com> Signed-off-by: Pierluigi Lenoci <pierluigilenoci@gmail.com>
Author
|
Hi — friendly ping. Is this PR still on the radar for review? Happy to rebase or make changes if needed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
klog v2 defaults
-logtostderr=true, which causes the-stderrthresholdflag to be silently ignored (kubernetes/klog#212).klog v2.140.0 introduced the
legacy_stderr_threshold_behaviorflag that restores correct behavior (kubernetes/klog#432).Changes
k8s.io/klog/v2from v2.130.1 to v2.140.0 in both the root module and thekubectl-utilssubmodule.klog.InitFlags()call (cmd/main.goandkubectl-utils/cmd/kubectl-expect/main.go), setlegacy_stderr_threshold_behavior=falseandstderrthreshold=INFOso that-stderrthresholdis honored regardless of-logtostderr.Why it matters
Without this fix, any user or operator trying to control log verbosity via
-stderrthresholdgets no effect because-logtostderr=trueshort-circuits the threshold check. This is a long-standing klog quirk that affects all consumers.Testing
go build ./cmd/...— passesgo build ./kubectl-utils/cmd/kubectl-expect/...— passes-stderrthresholdis not explicitly set; existing log routing is preserved.