WIP: Add VS Code provider controls#962
Closed
techbrewboss wants to merge 1 commit into
Closed
Conversation
Vasanthdev2004
requested changes
May 8, 2026
Collaborator
Vasanthdev2004
left a comment
There was a problem hiding this comment.
Targeted maintainer triage of current head 98c4902d12e328ec45576220c91f94f51ec2c8b4; not a full code review because this is marked WIP/draft and is not mergeable.
Verdict: Needs changes
Blocking issues:
- GitHub reports the branch as conflicting/dirty with
main; please rebase and resolve conflicts first. - The current check result is from April 30 and predates a lot of extension/provider-manager work on
main, so it is not enough signal for merge readiness anymore. - The PR overlaps with sensitive extension provider controls and profile persistence behavior. After rebase, please rerun the VS Code extension tests plus the provider validation tests listed in the PR body and update the PR with the new results.
Once the branch is current and no longer WIP, this can get a real code review against the latest extension architecture.
Collaborator
Author
|
Doing a fresh pr with updates |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #961
Validation