fix: DeepSeek V4 compatibility in thinking mode#925
fix: DeepSeek V4 compatibility in thinking mode#925Denis-666 wants to merge 1 commit intoGitlawb:mainfrom
Conversation
|
This PR is ready for review. The merge is currently blocked by the repository protection rule requiring approval from someone other than the last pusher, and code quality results are still pending. Could a maintainer please review / approve / trigger the checks when convenient? Thanks. |
|
#910 would be bocker for this at the moment. |
gnanam1990
left a comment
There was a problem hiding this comment.
Nice work — reasoning_content preservation across split assistant chunks is the right approach, and the recovery fallback for older transcripts is a good touch. Regression tests are present.
Heads up: this overlaps with #918 in openaiShim.convertMessages. Suggest letting the smaller #918 land first and rebasing this on top to keep the diff focused. Approving as-is; happy either way on merge order.
|
#910 touches openaiShim a lot. |
|
Hello @Denis-666 kindly rebase to main and fix conflicts we have a major change in provider onboarding and it affects a lot files. |
English
This PR fixes DeepSeek V4 compatibility in thinking mode.
reasoning_contentfor DeepSeek assistant messages with tool calls.deepseek-v4-pro?reasoning=xhighdefaults.Validation:
npx --yes bun@1.3.11 test src/services/api/openaiShim.test.ts src/utils/conversationRecovery.hooks.test.ts --timeout 20000No real API keys are included.
中文
这个 PR 修复 DeepSeek V4 thinking mode 的兼容性问题。
reasoning_content。deepseek-v4-pro?reasoning=xhigh。验证:
npx --yes bun@1.3.11 test src/services/api/openaiShim.test.ts src/utils/conversationRecovery.hooks.test.ts --timeout 20000没有包含真实 API key。