Skip to content

fix(openaiShim): unconditionally set reasoning_content for DeepSeek V… #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skeeminator wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −3
Open

fix(openaiShim): unconditionally set reasoning_content for DeepSeek V… #918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/services/api/openaiShim.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,9 +539,11 @@ function convertMessages(
// (harmless) or strict-reject unknown fields (harmful).
if (preserveReasoningContent) {
const thinkingText = (thinkingBlock as { thinking?: string } | undefined)?.thinking
if (typeof thinkingText === 'string' && thinkingText.trim().length > 0) {
assistantMsg.reasoning_content = thinkingText
}
// DeepSeek V4 (and similar reasoning providers) require reasoning_content
// to be present on every assistant message, even as empty string, when
// thinking mode is enabled. The field's presence satisfies the API contract;
// omitting it causes 400: "reasoning_content must be passed back to the API".
assistantMsg.reasoning_content = typeof thinkingText === 'string' ? thinkingText : ''
}

if (toolUses.length > 0) {
Expand Down Expand Up @@ -635,6 +637,12 @@ function convertMessages(
})(),
}

// Reasoning providers require reasoning_content on every assistant
// message when thinking mode is active (empty string is accepted).
if (preserveReasoningContent) {
assistantMsg.reasoning_content = ''
}

if (assistantMsg.content) {
result.push(assistantMsg)
}
Expand All @@ -659,6 +667,7 @@ function convertMessages(
coalesced.push({
role: 'assistant',
content: '[Tool execution interrupted by user]',
reasoning_content: '',
})
}

Expand Down
Loading