Skip to content

Fix to exception handling for XLSX #14138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
giohappy wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix to exception handling for XLSX #14138

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fcbe08f
Fix exception handling for XLSX
giohappy Apr 14, 2026
0d88790
Enhance error logging in XLSX handler
giohappy Apr 14, 2026
474178b
Log exception details during XLSX processing
giohappy Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions geonode/upload/handlers/xlsx/handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,9 +213,9 @@ def pre_processing(self, files, execution_id, **kwargs):
# Note: rows_gen continues from the row after the headers
self._convert_to_csv(headers, rows_gen, output_file)

except Exception as e:
except Exception:
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The generic except Exception block will catch all exceptions, including InvalidInputFileException instances raised earlier in the try block (e.g., from _validate_sheets, _validate_headers, or when the file is empty). This causes specific validation error messages to be replaced by the generic "Failed to securely parse Excel." message, which will cause existing tests like test_pre_processing_fails_on_missing_lat and test_pre_processing_fails_on_wrong_data to fail.

To preserve helpful validation feedback while still preventing information exposure from unexpected internal errors, catch InvalidInputFileException separately and re-raise it.

Suggested change
except Exception:
except InvalidInputFileException:
raise
except Exception:

logger.exception("XLSX Pre-processing failed")
raise InvalidInputFileException(detail=f"Failed to securely parse Excel: {str(e)}")
raise InvalidInputFileException(detail="Failed to securely parse Excel.")

# update the file path in the payload
_data["files"]["base_file"] = output_file
Expand Down
Loading