Figure.pygmtlogo: Improved positioning of vertical wordmark for circular PyGMT logo#4637
Open
seisman wants to merge 2 commits into
Open
Figure.pygmtlogo: Improved positioning of vertical wordmark for circular PyGMT logo#4637seisman wants to merge 2 commits into
seisman wants to merge 2 commits into
Conversation
Contributor
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)Report last updated at commit 834ea25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This is a follow-up PR to #4627. See PR #4627 for additional context.
The script demonstrates two different approaches for centering the wordmark beneath the visual logo. Version 1 is simpler, but the centering is only approximate. Version 2 uses the font metrics to achieve exact centering.
Additional notes for Version 2:
The top of the letter
Galigns aty=-4.5, rather than the tops of the lettersPMTAlternatively, it would also be possible to:
PMTaty=-4.5, orPMTaty=-5.5We may also want to ensure it also works well with hexagon shape, but it's always easier to decide an initial version for circular logo first, then revise it later when working on hexagon logos.