More precise error for lexing errors - #265
Merged
Merged
Conversation
When lexing of a quoted symbol in smt-lib failed, due to the structure of the lexer, the error was reported as an invalid cahracter on the pipe that started the quoted symbol, which was quite misleading (although technically correct). This is fixed in two ways: - change the parser so that the error can be raised on the invalid char inside of ther quoted symbol (possible in smt-lib because a pipe can only be the start of a quoted symbol) - the lexing error raised by lexer now carry the context of where the lexer was, allowing to specify e.g. that a character is invalid inside of a comment/string/quoted symbol
Gbury
force-pushed
the
better_lexing_error
branch
from
July 29, 2026 11:30
fc4c388 to
7debe8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When lexing of a quoted symbol in smt-lib failed, due to the structure of the lexer, the error was reported as an invalid cahracter on the pipe that started the quoted symbol, which was quite misleading (although technically correct). This is fixed in two ways:
See e.g. the discussion in SMT-LIB/benchmark-submission#12