Api endpoints to manage base configuration files for templates#2752
Open
Volo6uev wants to merge 7 commits into
Open
Api endpoints to manage base configuration files for templates#2752Volo6uev wants to merge 7 commits into
Volo6uev wants to merge 7 commits into
Conversation
Contributor
Author
|
Hello, I strictly implemented 3 endpoints in api/routes/controller/templates.py, service methods for them and tests. Tests for my code are passing. But tests for pytest tests/api/routes/controller/test_users.py are failing. These failures already existed locally before my changes and are related to authentication/session handling. What should we do? |
Member
|
I am going to review soon. Thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.