Skip to content

Fix: changing volume by scrolling does not work in some parts of the player#9447

Merged
FreeTubeBot merged 1 commit into
FreeTubeApp:developmentfrom
Shadorc:fix/volume-hover
Jul 19, 2026
Merged

Fix: changing volume by scrolling does not work in some parts of the player#9447
FreeTubeBot merged 1 commit into
FreeTubeApp:developmentfrom
Shadorc:fix/volume-hover

Conversation

@Shadorc

@Shadorc Shadorc commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

closes #7942

Description

Explanation here: #7942 (comment)
And I've added shaka-spacer which seems to be a new element hovering the player.
It was causing scrolling behavior instead of changing volume when hovering top part of the player.
image

Testing

  1. Enable Settings > Player > Scroll Volume Over Video Player
  2. Check that volume can be changed when hovering any part of the player

Desktop

  • OS: Bazzite
  • OS Version:
  • FreeTube version: v0.25.0-beta

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) July 17, 2026 19:03
@github-actions github-actions Bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jul 17, 2026
auto-merge was automatically disabled July 18, 2026 08:26

Head branch was pushed to by a user without write access

@Shadorc
Shadorc force-pushed the fix/volume-hover branch from cdd9ab1 to 7b1f237 Compare July 18, 2026 08:26
@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) July 18, 2026 08:26
@FreeTubeBot
FreeTubeBot merged commit 9eb03b8 into FreeTubeApp:development Jul 19, 2026
6 checks passed
@github-actions github-actions Bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jul 19, 2026
@Shadorc
Shadorc deleted the fix/volume-hover branch July 23, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Changing volume by scrolling over any part of video player

5 participants