Fix: "Hide videos from channels" doesn't work for collab videos (local API)#9421
Draft
Shadorc wants to merge 6 commits into
Draft
Fix: "Hide videos from channels" doesn't work for collab videos (local API)#9421Shadorc wants to merge 6 commits into
Shadorc wants to merge 6 commits into
Conversation
Member
|
I think you might want to request for review after it's ready next time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR is currently open pending the merge and release of LuanRT/YouTube.js#1203.
For now, it's open as a test case for that upstream change.
Pull Request Type
Related issue
Closes #7871 only for local API.
This does not fix the issue for Invidious API as collaborators are not supported either: iv-org/invidious#5507
Description
Fix "Hide videos from channels" setting not working with videos having collaborators.
Changes implemented for:
It can't be implemented in playlist or channel because YouTube does not provide this data, only a raw string like "Foo and 2 more". However, the setting is not intended to work in those places so that's fine.
Tested with both Local API and Invidious
Testing
// TODO
Desktop