Add an error for broadcasting with CUDA + complex numbers, etc#1225
Closed
mcabbott wants to merge 4 commits intoFluxML:masterfrom
Closed
Add an error for broadcasting with CUDA + complex numbers, etc#1225mcabbott wants to merge 4 commits intoFluxML:masterfrom
mcabbott wants to merge 4 commits intoFluxML:masterfrom
Conversation
mcabbott
commented
May 12, 2022
Contributor
|
I think making this an error is a good idea. Ideally there would be a way to not error for custom types when you know it is okay to not track the gradients. I guess you can define |
Member
Author
|
Yes. I guess the thing you overload should eventually be something like JuliaDiff/ChainRulesCore.jl#528 However, at the moment I believe you get errors from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Xref #1215