Skip to content

fix: flowise 370#6409

Open
0xi4o wants to merge 3 commits into
mainfrom
fix/flowise-370
Open

fix: flowise 370#6409
0xi4o wants to merge 3 commits into
mainfrom
fix/flowise-370

Conversation

@0xi4o
Copy link
Copy Markdown
Contributor

@0xi4o 0xi4o commented May 19, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new 'executions:update' permission to the RBAC system, applying it to the server-side execution update route and corresponding UI elements in the execution details and sharing dialogs. While the backend changes correctly secure the update endpoint, the reviewer noted that wrapping the 'Public' status chip in the UI with this permission is overly restrictive. This change prevents view-only users from seeing that an execution is public or accessing the shareable link, even though the 'Unshare' action is already independently protected within the dialog.

Comment thread packages/ui/src/views/agentexecutions/ExecutionDetails.jsx Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants