Skip to content

Don't clear listeners at the end of dismissSheet() animation. #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Taresin merged 1 commit into from
Nov 29, 2016
Merged

Don't clear listeners at the end of dismissSheet() animation. #167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions bottomsheet/src/main/java/com/flipboard/bottomsheet/BottomSheetLayout.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,7 +693,7 @@ public void onLayoutChange(View sheetView, int left, int top, int right, int bot
public void dismissSheet() {
dismissSheet(null);
}

private void dismissSheet(Runnable runAfterDismissThis) {
if (state == State.HIDDEN) {
runAfterDismiss = null;
Expand Down Expand Up @@ -723,8 +723,6 @@ public void onAnimationEnd(Animator animation) {

// Remove sheet specific properties
viewTransformer = null;
onSheetDismissedListeners.clear();
onSheetStateChangeListeners.clear();
if (runAfterDismiss != null) {
runAfterDismiss.run();
runAfterDismiss = null;
Expand Down Expand Up @@ -835,6 +833,8 @@ public void setUseHardwareLayerWhileAnimating(boolean useHardwareLayerWhileAnima

/**
* Adds an {@link OnSheetStateChangeListener} which will be notified when the state of the presented sheet changes.
* The listener will not be automatically removed, so remember to remove it when it's no longer needed
* (probably when the sheet is HIDDEN)
*
* @param onSheetStateChangeListener the listener to be notified.
*/
Expand All @@ -845,6 +845,8 @@ public void addOnSheetStateChangeListener(@NonNull OnSheetStateChangeListener on

/**
* Adds an {@link OnSheetDismissedListener} which will be notified when the state of the presented sheet changes.
* The listener will not be automatically removed, so remember to remove it when it's no longer needed
* (probably when the sheet is HIDDEN)
*
* @param onSheetDismissedListener the listener to be notified.
*/
Expand Down