Skip to content

fix(Change Requests): Revamp docs, improve UX#7709

Open
emyller wants to merge 11 commits into
mainfrom
fix/segment-change-requests-docs-ux
Open

fix(Change Requests): Revamp docs, improve UX#7709
emyller wants to merge 11 commits into
mainfrom
fix/segment-change-requests-docs-ux

Conversation

@emyller

@emyller emyller commented Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Rogue PR resulting from customer support work.

  • Improves UI around feature overrides
  • Disambiguates feature and segment change requests
  • Rewrite change requests docs
  • Adds missing permissions to RBAC docs

How did you test this code?

Manually checked visual changes, and you can too:

New documentation: https://docs-git-fix-segment-change-requests-docs-ux-flagsmith.vercel.app/administration-and-security/governance-and-compliance/change-requests

UI screenshots:

Before:
image

After:
image

Before:
image

After — contains some extra UI unrelated with changes:
image

@vercel

vercel Bot commented Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Jun 8, 2026 1:09pm
flagsmith-frontend-preview Ready Ready Preview, Comment Jun 8, 2026 1:09pm
flagsmith-frontend-staging Ready Ready Preview, Comment Jun 8, 2026 1:09pm

Request Review

@github-actions github-actions Bot added front-end Issue related to the React Front End Dashboard api Issue related to the REST API docs Documentation updates labels Jun 4, 2026
@emyller emyller changed the title Fix/segment change requests docs ux fix(Change Requests): Revamp docs, improve UX Jun 4, 2026
@emyller emyller marked this pull request as ready for review June 4, 2026 18:42
@emyller emyller requested review from a team as code owners June 4, 2026 18:42
@emyller emyller requested review from Holmus, khvn26 and kyle-ssg and removed request for a team June 4, 2026 18:42
@github-actions github-actions Bot removed the docs Documentation updates label Jun 4, 2026
@github-actions github-actions Bot added fix and removed fix labels Jun 4, 2026
@github-actions

github-actions Bot commented Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-7709 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-7709 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7709 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-7709 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7709 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-7709 Finished ✅ Results ✅

@codecov

codecov Bot commented Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.52%. Comparing base (cbcac64) to head (88a4ecf).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7709   +/-   ##
=======================================
  Coverage   98.52%   98.52%           
=======================================
  Files        1444     1444           
  Lines       54971    54971           
=======================================
  Hits        54161    54161           
  Misses        810      810

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@emyller @claude
Tolerate version specifiers when deriving uv version for install
88a4ecf 
The uv bump in #7708 changed tool.uv.required-version from a pinned
"0.11.14" to a range ">=0.11.18". The install-uv Make target derived
UV_VERSION via lstrip("="), which leaves the ">=" prefix intact and
produces the invalid pip requirement "uv==>=0.11.18", failing every API
image build. Strip leading comparator characters so the derived version
is a bare "0.11.18".

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions github-actions Bot added docs Documentation updates fix and removed fix docs Documentation updates labels Jun 4, 2026
@github-actions

github-actions Bot commented Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  35.1 seconds
commit  88a4ecf
info  🔄 Run: #17262 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  45.3 seconds
commit  88a4ecf
info  🔄 Run: #17262 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  44.2 seconds
commit  88a4ecf
info  🔄 Run: #17262 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  1 minute, 6 seconds
commit  88a4ecf
info  🔄 Run: #17262 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  40.7 seconds
commit  3b5e2a7
info  🔄 Run: #17340 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  19 passed

Details

stats  19 tests across 15 suites
duration  1 minute, 7 seconds
commit  3b5e2a7
info  🔄 Run: #17340 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  43.9 seconds
commit  3b5e2a7
info  🔄 Run: #17340 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  35.1 seconds
commit  3b5e2a7
info  🔄 Run: #17340 (attempt 1)

@github-actions

github-actions Bot commented Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

@emyller emyller assigned emyller and talissoncosta and unassigned khvn26, Holmus and kyle-ssg Jun 5, 2026
@matthewelwell

matthewelwell commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

/gemini review

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jun 8, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation and frontend UI to clearly distinguish between 'Feature Change Requests' (environment-level) and 'Segment Change Requests' (project-level). It renames various UI labels, updates the RBAC and Change Requests documentation, refactors the Identity and Segment Overrides tabs to improve layout and clarify behavior, and replaces '4-eyes' terminology with 'four-eyes'. Additionally, it updates the uv package manager's required version specification in the API configuration. There are no review comments, and I have no feedback to provide.

@github-actions github-actions Bot added the docs Documentation updates label Jun 8, 2026
@github-actions github-actions Bot added fix and removed fix docs Documentation updates labels Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Holmus Holmus Awaiting requested review from Holmus Holmus is a code owner automatically assigned from Flagsmith/flagsmith-docs

@kyle-ssg kyle-ssg Awaiting requested review from kyle-ssg kyle-ssg is a code owner automatically assigned from Flagsmith/flagsmith-front-end

@khvn26 khvn26 Awaiting requested review from khvn26 khvn26 was automatically assigned from Flagsmith/flagsmith-back-end

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@emyller emyller

@talissoncosta talissoncosta

Labels

api Issue related to the REST API fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@emyller @matthewelwell @khvn26 @talissoncosta @Holmus @kyle-ssg