Skip to content

July 2026 upgrades - #60

Merged
tcmg merged 4 commits into
mainfrom
july-2026-upgrades
Jul 17, 2026
Merged

July 2026 upgrades#60
tcmg merged 4 commits into
mainfrom
july-2026-upgrades

Conversation

@tcmg

@tcmg tcmg commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Tom Greenaway added 4 commits July 17, 2026 13:31
…n support, and refactor image processing for better performance.
…n generated images, and refactor border styling logic
…nstructions and update dependency lockfiles
@tcmg
tcmg merged commit 5dd7573 into main Jul 17, 2026
6 checks passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for new AI models and backends (such as Omni and Gemini Animation), updates the project's documentation and configuration from Firebase Studio to Antigravity, and improves image processing, error handling, and caching. Key feedback includes addressing a potential unhandled file-not-found error in the Gemini animation frame generation when safety filters block an image, removing redundant variable re-declarations in the image processing helper, and reverting temporary changes to the default starting scene that bypass the main menu.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +588 to +594
await generateImageWithGemini(
"gemini_anim_frame",
objectType,
lastFrameImageData,
visualStyle,
currentFramePath
);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

If the Gemini image generation is blocked by safety filters, generateImageWithGemini returns "__BLOCKED__" and does not write to currentFramePath. This will cause the subsequent fs.readFileSync(currentFramePath) call to throw a FileNotFound (ENOENT) error. You should check the return value and handle the blocked case gracefully.

Suggested change
await generateImageWithGemini(
"gemini_anim_frame",
objectType,
lastFrameImageData,
visualStyle,
currentFramePath
);
const resultPath = await generateImageWithGemini(
"gemini_anim_frame",
objectType,
lastFrameImageData,
visualStyle,
currentFramePath
);
if (resultPath === "__BLOCKED__") {
throw new Error(`Gemini animation frame ${i} generation was blocked by safety filters`);
}

Comment on lines +81 to +83
const cornerRadius = 16;
const borderWidth = 4; // Uniform border width around all sides
const borderColor = "black"; // Border color

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The variables cornerRadius, borderWidth, and borderColor are already declared at the top of the function (lines 65-67). Re-declaring them here inside the try block shadows the outer variables, which is redundant and confusing. Consider removing the outer declarations if they are no longer needed, or avoid re-declaring them here.


create() {
this.scene.start('StageClean');
this.scene.start('IOPuzzle_Fire');

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The default starting scene has been changed to 'IOPuzzle_Fire'. This bypasses the main menu and sandbox stage, which appears to be a leftover from local testing/debugging. Please verify if this should be reverted to 'StageClean' before merging.

Suggested change
this.scene.start('IOPuzzle_Fire');
this.scene.start('StageClean');


this.input.once('pointerdown', () => {
this.scene.start('StageClean');
this.scene.start('IOPuzzle_Fire');

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The scene started upon pointer down has been changed to 'IOPuzzle_Fire'. This bypasses the sandbox stage ('StageClean'), which appears to be a leftover from local testing/debugging. Please verify if this should be reverted to 'StageClean'.

Suggested change
this.scene.start('IOPuzzle_Fire');
this.scene.start('StageClean');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant