Skip to content

fix(security): move session credentials to sessionStorage #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Namraa310806 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(security): move session credentials to sessionStorage #547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions frontend/src/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ function MainApp() {

const loadKnownSessions = React.useCallback(() => {
try {
const raw = localStorage.getItem(SESSION_STORAGE_KEY);
const raw = sessionStorage.getItem(SESSION_STORAGE_KEY);
if (!raw) return [];
const parsed = decodePayload(raw);
if (!Array.isArray(parsed)) return [];
Expand Down Expand Up @@ -150,11 +150,11 @@ function MainApp() {
...existing.filter((s) => s.session_id !== normalizedSessionId),
];
try {
localStorage.setItem(SESSION_STORAGE_KEY, encodePayload(next.slice(0, 50)));
sessionStorage.setItem(SESSION_STORAGE_KEY, encodePayload(next.slice(0, 50)));
} catch (_) {
// sessionStorage quota exceeded — prune to 10 most recent and retry once.
try {
localStorage.setItem(SESSION_STORAGE_KEY, encodePayload(next.slice(0, 10)));
sessionStorage.setItem(SESSION_STORAGE_KEY, encodePayload(next.slice(0, 10)));
} catch (_) {}
}
},
Expand Down
9 changes: 5 additions & 4 deletions frontend/src/App.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,14 @@ function loadKnownSessions() {
(s) =>
s &&
typeof s.session_id === "string" &&
s.session_id.trim() !== "" &&
typeof s.session_secret === "string" &&
s.session_secret.trim() !== "",
s.session_id.trim() !== "",
)
.map((s) => ({
session_id: s.session_id.trim(),
session_secret: s.session_secret.trim(),
session_secret:
typeof s.session_secret === "string" && s.session_secret.trim() !== ""
? s.session_secret.trim()
: null,
}));
} catch (_) {
return [];
Expand Down
Loading