Skip to content

Fix issue #523: Add loading spinner during document upload#530

Open
Aditya948351 wants to merge 1 commit into
FireFistisDead:masterfrom
Aditya948351:issue523
Open

Fix issue #523: Add loading spinner during document upload#530
Aditya948351 wants to merge 1 commit into
FireFistisDead:masterfrom
Aditya948351:issue523

Conversation

@Aditya948351

@Aditya948351 Aditya948351 commented Jun 14, 2026

Copy link
Copy Markdown

Summary

Describe what changed and why.

Related issue

Closes #523

Testing

  • I ran the relevant checks locally
  • I verified the app still starts
  • I tested the affected flow end-to-end

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Screenshots / recordings

Add screenshots or recordings if the UI changed.

Notes

Mention any deployment, environment, or follow-up details.

Security

  • No sensitive data included
    3

Copilot AI review requested due to automatic review settings June 14, 2026 17:27
@vercel

vercel Bot commented Jun 14, 2026

Copy link
Copy Markdown

@Aditya948351 is attempting to deploy a commit to the firefistisdead's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

In UploadCard.jsx, the static CloudUploadIcon in the upload icon area is replaced with conditional rendering: a CircularProgress spinner is shown when uploading is true, and CloudUploadIcon with adjusted sizing is shown when uploading is false.

Changes

Upload Spinner Feedback

Layer / File(s) Summary
Conditional spinner vs. upload icon
frontend/src/components/UploadCard/UploadCard.jsx
Renders CircularProgress when uploading is true; falls back to CloudUploadIcon with updated size styling when uploading is false.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

Poem

🐇 A spinner now twirls when files take flight,
No more plain cloud just sitting in sight.
While bytes travel up to the digital sky,
A circle goes round — oh my, oh my!
The rabbit hops proud, for feedback is bright! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is largely incomplete. The Summary section contains only placeholder template text without actual details about changes. Testing checkboxes are unchecked and substantive sections are missing. Fill in the Summary section with a clear description of what changed and why. Check the Testing checkboxes to indicate which tests were performed. Add screenshots if UI changes were made, and provide any relevant deployment notes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding a loading spinner during document upload, and references the issue being fixed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added docs Documentation only feature A new feature or improvement fix A targeted fix or cleanup frontend Frontend-related work level:advanced type:security type:testing labels Jun 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation only feature A new feature or improvement fix A targeted fix or cleanup frontend Frontend-related work level:advanced type:security type:testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add loading spinner during document upload

2 participants