Skip to content

97187: Android - Show history button is not displayed in Concierge chat - #99605

Draft
abbasifaizan70 wants to merge 2 commits into
Expensify:mainfrom
abbasifaizan70:97187
Draft

97187: Android - Show history button is not displayed in Concierge chat#99605
abbasifaizan70 wants to merge 2 commits into
Expensify:mainfrom
abbasifaizan70:97187

Conversation

@abbasifaizan70

Copy link
Copy Markdown
Contributor

Explanation of Change

On the Concierge main DM (native only — web/mWeb use the side panel), full history was being force-shown whenever the Concierge report had an incomplete child task. Concierge posts onboarding items as child tasks, so on any account with one left undone that stayed on permanently — which both un-hid the history and suppressed the "Show history" button entirely. That's exactly what's reported here, and it affects iOS as well as Android.

This PR drops that condition. The deep-link condition next to it is left alone, since forcing full history there is intentional.

To avoid burying a task the user still needs to act on — the reason the condition was added in #88769, whose test plan required a Concierge DM with no pending tasks — a still-open child task is now kept in the current session view instead. The pending task stays visible while the rest of the read history collapses behind "Show history"; a completed task collapses with everything else.

Fixed Issues

$ #97187
PROPOSAL: #97187 (comment)

Tests

  • Verify that no errors appear in the JS console

Precondition: an account with prior Concierge history and at least one incomplete Concierge task in that DM (e.g. a "Take a test drive" onboarding task left undone).

  1. Open the app on Android (or iOS) and go to any chat or workspace chat.
  2. Tap the search icon top right.
  3. Type a question for Concierge, e.g. "How to connect QBD".
  4. Tap "Ask Concierge" below the search results.
  5. Verify only your just-sent question is shown, with "Concierge is thinking…" underneath — the older history is not expanded.
  6. Verify a "Show history" divider button appears above it.
  7. Verify the incomplete task is still visible in the collapsed view.
  8. Wait for the reply and verify the question + reply stay visible and the panel doesn't collapse to "Hi there, how can I help?".
  9. Tap "Show history" and verify the full prior conversation loads.
  10. Complete the task, reopen the Concierge DM, and verify the completed task now hides with the rest of the history.

Offline tests

Same as tests.

QA Steps

  • Verify that no errors appear in the JS console

Same as tests.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen_Recording_20260827_021418_New.Expensify.Dev.mp4
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant