97187: Android - Show history button is not displayed in Concierge chat - #99605
Draft
abbasifaizan70 wants to merge 2 commits into
Draft
97187: Android - Show history button is not displayed in Concierge chat#99605abbasifaizan70 wants to merge 2 commits into
abbasifaizan70 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
On the Concierge main DM (native only — web/mWeb use the side panel), full history was being force-shown whenever the Concierge report had an incomplete child task. Concierge posts onboarding items as child tasks, so on any account with one left undone that stayed on permanently — which both un-hid the history and suppressed the "Show history" button entirely. That's exactly what's reported here, and it affects iOS as well as Android.
This PR drops that condition. The deep-link condition next to it is left alone, since forcing full history there is intentional.
To avoid burying a task the user still needs to act on — the reason the condition was added in #88769, whose test plan required a Concierge DM with no pending tasks — a still-open child task is now kept in the current session view instead. The pending task stays visible while the rest of the read history collapses behind "Show history"; a completed task collapses with everything else.
Fixed Issues
$ #97187
PROPOSAL: #97187 (comment)
Tests
Precondition: an account with prior Concierge history and at least one incomplete Concierge task in that DM (e.g. a "Take a test drive" onboarding task left undone).
Offline tests
Same as tests.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen_Recording_20260827_021418_New.Expensify.Dev.mp4
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari